Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8362286

[vectorapi] Make VectorOperators.SUADD an Associative

XMLWordPrintable

    • Icon: CSR CSR
    • Resolution: Approved
    • Icon: P4 P4
    • 26
    • core-libs
    • None
    • source
    • minimal
    • Minimal compatibility risk. Incubator API and type changes to subclass of existing type with no behavioral changes to existing behavior.
    • Java API
    • JDK

      Summary

      Retroactive CSR for linked issue. Noticed late this affected a public field in the Vector API incubator.

      The SUADD field in src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorOperators.java is being changed from Binary to Associative, a subtype of Binary.

      Problem

      The SUADD lane-wise operation is associative but is not type as such in VectorOperators

      Solution

      Updating the relevant flags on this public field and changing its type from Binary to Associative.

      Specification

      diff --git a/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorOperators.java b/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorOperators.java
      index 0e231bd5174..f4da4f42934 100644
      --- a/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorOperators.java
      +++ b/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorOperators.java
      @@ -577,7 +577,7 @@ static boolean opKind(Operator op, int bit) {
           /** Produce saturating unsigned {@code a+b}.  Integral only.
            * @see VectorMath#addSaturatingUnsigned(int, int)
            */
      -    public static final Binary SUADD = binary("SUADD", "+", VectorSupport.VECTOR_OP_SUADD, VO_NOFP);
      +    public static final Associative SUADD = assoc("SUADD", "+", VectorSupport.VECTOR_OP_SUADD, VO_NOFP+VO_ASSOC);
           /** Produce saturating {@code a-b}.  Integral only.
            * @see VectorMath#subSaturating(int, int)
            */

            igraves Ian Graves
            qmai Quan Anh Mai
            Joe Darcy
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: