Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-1233

Legal bot fails to approve review comments

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P2 P2
    • None
    • None
    • bots
    • None

      When a new github user leaves a message in a PR, the legal bot hides the message with a welcome message and a click box to accept our TOU. If this comment is instead made as a review, then clicking the box seems to have no effect. The bot just removes the tick and never restores the comment. The user is also never added to the approvals DB file.

      If the user adds a plain comment after and approves the TOU in that, the new comment gets restored, but the review comment is stuck with the greeting and tick box.

      Here is a link to such a case: https://github.com/openjdk/jfx/pull/499#pullrequestreview-793131154

            erikj Erik Joelsson
            erikj Erik Joelsson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: