# HG changeset patch # Parent 04dfdd1ed7be14f73dcf784ccd23ed5164b9c0ea RT-33145: In SkinBase computeMinHeight and computeMinWidth, initialize minY/minX to max value and maxY/maxX to min value. diff -r 04dfdd1ed7be modules/controls/src/main/java/javafx/scene/chart/PieChart.java --- a/modules/controls/src/main/java/javafx/scene/chart/PieChart.java Wed Oct 02 15:26:04 2013 -0400 +++ b/modules/controls/src/main/java/javafx/scene/chart/PieChart.java Thu Oct 03 08:41:30 2013 -0400 @@ -501,10 +501,10 @@ labelLinePath.getElements().clear(); // calculate combined bounds of all labels & pie radius - double minX = 0.0d; - double minY = 0.0d; - double maxX = 0.0d; - double maxY = 0.0d; + double minX = Double.MAX_VALUE; + double minY = Double.MAX_VALUE; + double maxX = Double.MIN_VALUE; + double maxY = Double.MIN_VALUE; double[] labelsX = null; double[] labelsY = null; double[] labelAngles = null; diff -r 04dfdd1ed7be modules/controls/src/main/java/javafx/scene/control/SkinBase.java --- a/modules/controls/src/main/java/javafx/scene/control/SkinBase.java Wed Oct 02 15:26:04 2013 -0400 +++ b/modules/controls/src/main/java/javafx/scene/control/SkinBase.java Thu Oct 03 08:41:30 2013 -0400 @@ -203,8 +203,8 @@ * @return A double representing the minimum width of this Skin. */ protected double computeMinWidth(double height, double topInset, double rightInset, double bottomInset, double leftInset) { - double minX = 0; - double maxX = 0; + double minX = Double.MAX_VALUE; + double maxX = Double.MIN_VALUE; for (int i = 0; i < children.size(); i++) { Node node = children.get(i); if (node.isManaged()) { @@ -230,8 +230,8 @@ * @return A double representing the minimum height of this Skin. */ protected double computeMinHeight(double width, double topInset, double rightInset, double bottomInset, double leftInset) { - double minY = 0; - double maxY = 0; + double minY = Double.MAX_VALUE; + double maxY = Double.MIN_VALUE; for (int i = 0; i < children.size(); i++) { Node node = children.get(i); if (node.isManaged()) { @@ -319,8 +319,8 @@ * @return the calculated preferred height */ protected double computePrefHeight(double width, double topInset, double rightInset, double bottomInset, double leftInset) { - double minY = 0; - double maxY = 0; + double minY = Double.MAX_VALUE; + double maxY = Double.MIN_VALUE; for (int i = 0; i < children.size(); i++) { Node node = children.get(i); if (node.isManaged()) { diff -r 04dfdd1ed7be modules/graphics/src/main/java/javafx/scene/layout/Region.java --- a/modules/graphics/src/main/java/javafx/scene/layout/Region.java Wed Oct 02 15:26:04 2013 -0400 +++ b/modules/graphics/src/main/java/javafx/scene/layout/Region.java Thu Oct 03 08:41:30 2013 -0400 @@ -543,7 +543,7 @@ // We have determined that the outsets of these two different background // objects is different, and therefore the bounds have changed. impl_geomChanged(); -// RT-30663 insets.fireValueChanged(); + insets.fireValueChanged(); } // No matter what, the fill has changed, so we have to update it impl_markDirty(DirtyBits.SHAPE_FILL);