diff -r 04d69a5db5e1 src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java --- a/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java Fri Mar 31 07:38:34 2017 -0700 +++ b/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java Sun Apr 02 14:59:53 2017 +0530 @@ -2107,10 +2107,12 @@ Name moduleName = tree.sym.name; Assert.checkNonNull(moduleName); if (lint.isEnabled(LintCategory.MODULE)) { - String moduleNameString = moduleName.toString(); - int nameLength = moduleNameString.length(); - if (nameLength > 0 && Character.isDigit(moduleNameString.charAt(nameLength - 1))) { - log.warning(Lint.LintCategory.MODULE, tree.qualId.pos(), Warnings.PoorChoiceForModuleName(moduleName)); + String [] moduleNameComponents = moduleName.toString().split("\\."); + for (String moduleNameString : moduleNameComponents) { + int nameLength = moduleNameString.length(); + if (nameLength > 0 && Character.isDigit(moduleNameString.charAt(nameLength - 1))) { + log.warning(Lint.LintCategory.MODULE, tree.qualId.pos(), Warnings.PoorChoiceForModuleName(moduleName)); + } } } } diff -r 04d69a5db5e1 test/tools/javac/modules/PoorChoiceForModuleNameTest.java --- a/test/tools/javac/modules/PoorChoiceForModuleNameTest.java Fri Mar 31 07:38:34 2017 -0700 +++ b/test/tools/javac/modules/PoorChoiceForModuleNameTest.java Sun Apr 02 14:59:53 2017 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2016, 2017 Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,7 +23,7 @@ /* * @test - * @bug 8160181 + * @bug 8160181 8176572 * @summary Add lint warning for digits in module names * @library /tools/lib * @modules @@ -63,6 +63,14 @@ Path src_m3 = src.resolve("mango100"); tb.writeJavaFiles(src_m3, "@SuppressWarnings(\"module\") module mango100 { }"); + // Check that there is no warning at use site. + Path src_m4 = src.resolve("mangouser"); + tb.writeJavaFiles(src_m4, "module mangouser { requires mango19; }"); + + // Check that we warn about component names ending in digit also + Path src_m5 = src.resolve("mango1000.mangomodule"); + tb.writeJavaFiles(src_m5, "module mango1000.mangomodule { }"); + Path classes = base.resolve("classes"); tb.createDirectories(classes); @@ -78,9 +86,10 @@ .getOutput(Task.OutputKind.DIRECT); if (!log.contains("module-info.java:1:8: compiler.warn.poor.choice.for.module.name: mango19") || + !log.contains("module-info.java:1:17: compiler.warn.poor.choice.for.module.name: mango1000.mangomodule") || !log.contains("- compiler.err.warnings.and.werror") || !log.contains("1 error") || - !log.contains("1 warning")) + !log.contains("2 warning")) throw new Exception("expected output not found: " + log); } }