## Code Review for jdk

Prepared by: | sundar on Tue Jun 26 10:22:58 IST 2018
Workspace: | /Users/SATHIJEG/src/jdk
Summary of changes: | 329 lines changed: 324 ins; 0 del; 5 mod; 11980 unchg
Patch of changes: | jdk.patch
Legend: | Modified file Deleted file New file

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` make/CompileJavaModules.gmk

> 2 lines changed: 2 ins; 0 del; 0 mod; 668 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` make/nashorn/project.properties

> 1 line changed: 1 ins; 0 del; 0 mod; 491 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn.shell/share/classes/jdk/nashorn/tools/jjs/Main.java

> 1 line changed: 1 ins; 0 del; 0 mod; 325 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn.shell/share/classes/module-info.java

> 1 line changed: 1 ins; 0 del; 0 mod; 47 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/linker/NashornLinkerExporter.java

> 1 line changed: 1 ins; 0 del; 0 mod; 60 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/AbstractJSObject.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 226 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/ClassFilter.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 43 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/JSObject.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 210 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/NashornException.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 296 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/NashornScriptEngine.java

> 8 lines changed: 8 ins; 0 del; 0 mod; 568 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 285 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/ScriptObjectMirror.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 921 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/ScriptUtils.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 188 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/URLReader.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 121 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/scripting/package-info.java

> 1 line changed: 1 ins; 0 del; 0 mod; 41 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ArrayAccessTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 52 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ArrayLiteralTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 42 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/AssignmentTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 52 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/BinaryTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 53 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/BlockTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 49 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/BreakTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 49 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/CaseTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 58 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/CatchTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 61 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ClassDeclarationTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 63 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ClassExpressionTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 63 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/CompilationUnitTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 73 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/CompoundAssignmentTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 53 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ConditionalExpressionTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 59 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ConditionalLoopTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 40 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ContinueTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 48 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/DebuggerTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 39 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/Diagnostic.java

> 5 lines changed: 5 ins; 0 del; 0 mod; 150 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/DiagnosticListener.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 41 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/DoWhileLoopTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 56 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/EmptyStatementTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 38 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ErroneousTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 34 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ExportEntryTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 60 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ExpressionStatementTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 45 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ExpressionTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 34 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ForInLoopTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 68 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ForLoopTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 69 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ForOfLoopTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 62 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/FunctionCallTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 56 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/FunctionDeclarationTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 83 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/FunctionExpressionTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 90 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/GotoTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 44 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/IdentifierTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 87 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/IfTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 66 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ImportEntryTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 53 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/InstanceOfTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 52 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/LabeledStatementTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 52 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/LineMap.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 53 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/LiteralTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 46 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/LoopTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 40 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/MemberSelectTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 52 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ModuleTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 60 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/NewTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 47 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ObjectLiteralTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 42 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ParenthesizedTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 46 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/Parser.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 163 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/PropertyTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 77 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/RegExpLiteralTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 47 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ReturnTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 47 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/SimpleTreeVisitorES5_1.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 521 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/SimpleTreeVisitorES6.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 226 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/SpreadTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 38 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/StatementTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 35 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/SwitchTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 57 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/TemplateLiteralTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 48 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/ThrowTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 45 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/Tree.java

> 5 lines changed: 5 ins; 0 del; 0 mod; 643 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/TreeVisitor.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 518 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/TryTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 66 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/UnaryTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 48 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/UnknownTreeException.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 82 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/VariableTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 71 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/WhileLoopTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 55 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/WithTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 53 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/YieldTree.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 66 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree/package-info.java

> 1 line changed: 1 ins; 0 del; 0 mod; 74 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/ScriptEnvironment.java

> 3 lines changed: 3 ins; 0 del; 0 mod; 485 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/resources/Options.properties

> 8 lines changed: 8 ins; 0 del; 0 mod; 430 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/jdk/nashorn/tools/Shell.java

> 3 lines changed: 3 ins; 0 del; 0 mod; 671 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/jdk.scripting.nashorn/share/classes/module-info.java

> 4 lines changed: 4 ins; 0 del; 0 mod; 163 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` test/jdk/sun/tools/jrunscript/jrunscript-eTest.sh

> 1 line changed: 0 ins; 0 del; 1 mod; 56 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` test/jdk/sun/tools/jrunscript/jrunscript-fTest.sh

> 1 line changed: 0 ins; 0 del; 1 mod; 57 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` test/jdk/sun/tools/jrunscript/jrunscriptTest.sh

> 1 line changed: 0 ins; 0 del; 1 mod; 61 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` test/jdk/tools/jjs/jjs-fileTest.sh

> 1 line changed: 0 ins; 0 del; 1 mod; 49 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` test/nashorn/script/nosecurity/JDK-8193137.js

> 1 line changed: 0 ins; 0 del; 1 mod; 58 unchg

This code review page was prepared using ../webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).