Code Review for JDK-8244202

Prepared by: Aleksei Efimov on Tue Oct 26 14:05:01 IST 2021
Compare against: https://github.com/openjdk/jdk
Compare against version: 4e647aa5
Summary of changes: 3138 lines changed; 2845 ins; 155 del; 138 mod; 5304 unchg
Patch of changes: JDK-8244202.patch
Bug id: JDK-8244202
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/RuntimePermission.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
11 lines changed; 10 ins; 0 del; 1 mod; 438 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/Inet4AddressImpl.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
11 lines changed; 9 ins; 0 del; 2 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/Inet6AddressImpl.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
17 lines changed; 7 ins; 2 del; 8 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/InetAddress.java

1378686b: Changes to address review comments
fa655be2: More javadoc updates to API classes
2a554c91: Review updates + move resolver docs to the provider class (CSR update to follow)
30226481: Change InetAddressResolver method names
648e65b8: Address review comments: javadoc + code cleanup
cd19ecd6: Address resolver bootstraping issue
b0386138: Add checks and test for empty stream resolver results
77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
429 lines changed; 219 ins; 121 del; 89 mod; 1425 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/InetAddressImpl.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
4 lines changed; 3 ins; 0 del; 1 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/doc-files/net-properties.html

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
2 lines changed; 0 ins; 0 del; 2 mod; 295 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/net/spi/InetAddressResolver.java

1378686b: Changes to address review comments
fa655be2: More javadoc updates to API classes
2a554c91: Review updates + move resolver docs to the provider class (CSR update to follow)
30226481: Change InetAddressResolver method names
d302a49a: Add @since tags to new API classes
77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
201 lines changed; 201 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/net/spi/InetAddressResolverProvider.java

1378686b: Changes to address review comments
fa655be2: More javadoc updates to API classes
2a554c91: Review updates + move resolver docs to the provider class (CSR update to follow)
d302a49a: Add @since tags to new API classes
77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
160 lines changed; 160 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/spi/package-info.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
3 lines changed; 0 ins; 0 del; 3 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/access/JavaNetInetAddressAccess.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
11 lines changed; 0 ins; 10 del; 1 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/module-info.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
1 lines changed; 1 ins; 0 del; 0 mod; 417 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/sun/net/ResolverProviderConfiguration.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
53 lines changed; 53 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libnet/InetAddress.c

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
13 lines changed; 9 ins; 3 del; 1 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libnet/net_util.c

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
21 lines changed; 21 ins; 0 del; 0 mod; 334 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libnet/net_util.h

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
5 lines changed; 4 ins; 1 del; 0 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnet/Inet4AddressImpl.c

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
7 lines changed; 4 ins; 0 del; 3 mod; 495 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libnet/Inet6AddressImpl.c

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
15 lines changed; 3 ins; 2 del; 10 mod; 695 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/native/libnet/Inet6AddressImpl.c

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
11 lines changed; 2 ins; 2 del; 7 mod; 491 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/AddressesCachingTest.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
104 lines changed; 104 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/BootstrapResolverUsageTest.java

cd19ecd6: Address resolver bootstraping issue  
49 lines changed; 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/BuiltInResolverTest.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
79 lines changed; 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/EmptyResultsStreamTest.java

b0386138: Add checks and test for empty stream resolver results  
52 lines changed; 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/ForeverCache.props

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
2 lines changed; 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/InetAddressUsageInGetProviderTest.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
44 lines changed; 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/LookupPolicyMappingTest.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
172 lines changed; 172 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/LookupPolicyOfTest.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
88 lines changed; 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/NeverCache.props

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
2 lines changed; 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/ProviderGetExceptionTest.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
63 lines changed; 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/ResolutionWithExceptionTest.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
94 lines changed; 94 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/ResolvePermissionTest.java

6aefbc95: Update tests to address SM deprecation
77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
95 lines changed; 95 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/ReverseLookupDelegationTest.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
62 lines changed; 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/RuntimePermissionTest.java

6aefbc95: Update tests to address SM deprecation
77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
100 lines changed; 100 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/addresses.txt

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
7 lines changed; 7 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/lib/test.library/module-info.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
27 lines changed; 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/lib/test.library/testlib/ResolutionRegistry.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
239 lines changed; 239 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/providers/bootstrapUsage/bootstrap.usage.provider/impl/WithBootstrapResolverUsageProvider.java

30226481: Change InetAddressResolver method names
648e65b8: Address review comments: javadoc + code cleanup
cd19ecd6: Address resolver bootstraping issue  
76 lines changed; 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/providers/bootstrapUsage/bootstrap.usage.provider/module-info.java

cd19ecd6: Address resolver bootstraping issue  
30 lines changed; 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/providers/delegating/delegating.provider/impl/DelegatingProviderImpl.java

30226481: Change InetAddressResolver method names
77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
68 lines changed; 68 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/providers/delegating/delegating.provider/module-info.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
29 lines changed; 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/providers/empty/empty.results.provider/impl/EmptyResultsProviderImpl.java

30226481: Change InetAddressResolver method names
b0386138: Add checks and test for empty stream resolver results  
56 lines changed; 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/providers/empty/empty.results.provider/module-info.java

b0386138: Add checks and test for empty stream resolver results  
29 lines changed; 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/providers/faulty/faulty.provider/impl/FaultyResolverProviderGetImpl.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
42 lines changed; 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/providers/faulty/faulty.provider/module-info.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
30 lines changed; 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/providers/recursive/recursive.init.provider/impl/InetAddressUsageInGetProviderImpl.java

30226481: Change InetAddressResolver method names
77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
63 lines changed; 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/providers/recursive/recursive.init.provider/module-info.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
30 lines changed; 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/providers/simple/simple.provider/impl/SimpleResolverProviderImpl.java

30226481: Change InetAddressResolver method names
77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
91 lines changed; 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/providers/simple/simple.provider/module-info.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
31 lines changed; 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/providers/throwing/throwing.lookups.provider/impl/ThrowingLookupsProviderImpl.java

30226481: Change InetAddressResolver method names
77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
73 lines changed; 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/providers/throwing/throwing.lookups.provider/module-info.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
29 lines changed; 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/serviceProviderOriginType/classpath/ClasspathProviderTest.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
49 lines changed; 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/serviceProviderOriginType/classpath/ClasspathResolverProviderImpl.java

30226481: Change InetAddressResolver method names
77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
67 lines changed; 67 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/serviceProviderOriginType/classpath/META-INF/services/java.net.spi.InetAddressResolverProvider

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
1 lines changed; 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/serviceProviderOriginType/classpath/addresses.txt

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
7 lines changed; 7 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/serviceProviderOriginType/module/ModularProviderTest.java

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
49 lines changed; 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/spi/InetAddressResolverProvider/serviceProviderOriginType/module/addresses.txt

77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
7 lines changed; 7 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/net/IPSupport.java

ac0d2184: Remove no longer used import from IPSupport
95a21e57: Rename IPSupport.hasAddress and update it to use SocketChannel.open
77551538: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI  
27 lines changed; 3 ins; 14 del; 10 mod; 129 unchg

This code review page was prepared using webrev version f7748c09a329465453187af57019a63caef55145