Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-6311046

-Xcheck:jni should support checking of GetPrimitiveArrayCritical

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P3
    • 9
    • 6
    • hotspot
    • b22
    • sparc
    • solaris_9

    Backports

      Description

        While debugging 6300721 I discovered that user code was walking off the end on a Java array being accessed using GetPrimitiveArrayCritical. Our implementation returns a pointer to the interior of the array so walking off the end stomps the java heap. It's permissible to return a copy and I think with -Xcheck:jni that's what we should do. We should return a chunk of memory with a guard region at each end and when ReleasePrimitiveArrayCritical is called the guard regions should be checked to see they are overwritten.
        We should also do this for Release/Get*ArrayElements. It would have been useful in diagnosing 6532325 as a JNI problem and not a JVM problem.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8063391 -Xcheck:jni should support checking of GetPrimitiveArrayCritical

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8070950 -Xcheck:jni should support checking of GetPrimitiveArrayCritical

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8054982 -Xcheck:jni should support checking of GetPrimitiveArrayCritical

            • P3 - Major loss of function.
            • Closed
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-6300721 Creating Animated GIF images repeatedly with different image frames crashes the VM

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. JDK-8046662 Check JNI ReleaseStringChars / ReleaseStringUTFChars verify_guards test inverted

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. JDK-6532325 VM crashes after setting file associations in Eclipse 3.2

            • P3 - Major loss of function.
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. JDK-8160614 Some of the checked JNI improvements are excessively verbose

            • P3 - Major loss of function.
            • Closed

            Activity

              People

                dsimms David Simms
                never Tom Rodriguez
                Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:
                  Imported:
                  Indexed: