Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8009751

(se) Selector spin when select, close and interestOps(0) invoked at same time (lnx)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8
    • Component/s: core-libs
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b84
    • Verification:
      Not verified

      Backports

        Description


        Sean Chou writes (see http://mail.openjdk.java.net/pipermail/nio-dev/2012-December/002073.html):

        "This is the detail problem, there is a small time window in which a 3
        threads race makes select() always return 0 without blocking.

        I wrote a testcase(http://cr.openjdk.java.net/~zhouyx/OJDK-714/webrev0.2/)
        which needs to modify the lib code to reproduce, because the time windows
        is small.

        The reproduce scenario is described in follow, use Tx for thread x:

        1. T1 (the user code) is selecting a channel(suppose C), it just returns
        from native select function, and niolib select method is checking if the
        returned channel is interested in the event, then 2 happens;
        2. T2 is closing channel C, it just set the open variable to false but not
        yet closed the channel actually, and then 3 happens;
        3. T3 set the interedOps of the channel to 0. // 0 means the channel is not
        interested in anything, the channel will be put into cancel list normally.

        In this senario, T1 returns from select, and return 0 which means no
        channel is selected(because the channel C returned from native invocation
        has nothing insterested in, it is not returned to application). Then T1
        goes to invoke select again(usually in a loop, this is how select is
        designed to be used). In normal case, select method checks if any channels
        those should be cancelled and remove them from the set to be selected.
        Then, goes to native select function.

        The problem is: select method first checks if the channel is closed, if it
        is closed, select method doesn't put it into cancel list.

        In above senario, channel C is in close state, but not closed indeed, and
        setInteredOps to 0(which means cancel). So select method doesn't put C into
        cancel list(due to the problem) which means the native select set still
        contains channel C . So the native select always return C and nio select
        always return 0. Until the channel is finally closed."

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                alanb Alan Bateman
                Reporter:
                alanb Alan Bateman
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved: