Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8029953

Backport ASM warning fixes to JDK 8

    XMLWordPrintable

    Details

    • Subcomponent:
    • Resolved In Build:
      b09
    • CPU:
      generic
    • OS:
      generic

      Description

      There were some last minute ASM changes discovered in Java 8, that had to do with the ambiguity of interface methods, and that interface methods can be called by other opcodes than invoke interface. This was fixed by specifying an extra " is interface " parameter to method.visitMethodInsn in ASM and deprecating the old one.

      Nashorn uses the old visitMethodInsn in a couple of places, and does not explicitly need to say that anything is an interface. We removed the use of the deprecated method in the JDK9 branch, basically by adding "false" or "true" arguments to this call where applicable, as we had a large number of compile time warnings.

      (Thus, this has currently been resolved in JDK9 with JDK-8029031, but I think it makes sense to backport it to openJDK8).

      I want to backport because it looks very unprofessional with a large number of deprecation warnings when building nashorn, and more importantly, because I've missed REAL warnings in the list of deprecation warnings. The fix would be very small and risk free and has been thoroughly tested in the 9 branch already. It is independent of everything else.

      See http://cr.openjdk.java.net/~sundar/8029031/ for web rev that I want to backport.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              lagergren Marcus Lagergren
              Reporter:
              lagergren Marcus Lagergren
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: