Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8035326

Assume non-NULL references in G1CollectedHeap::in_cset_fast_test

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 8u20, 9
    • Fix Version/s: 9
    • Component/s: hotspot
    • Subcomponent:
      gc
    • Resolved In Build:
      b04
    • CPU:
      x86

      Backports

        Description

        All but one invocations of G1CollectedHeap::in_cset_fast_test already assume or make sure that the referenced object is within the heap (since the perm gen removal).

        This additional check is superfluous, and decreases performance.

        Change G1CollectedHeap::in_cset_fast_test to not assume that the passed references are NULL references.

        The only place where NULL references were possible, is G1ParCopyClosure::do_oop_work(). However extracting the check out allows further code simplifications.

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                tschatzl Thomas Schatzl
                Reporter:
                tschatzl Thomas Schatzl
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved: