Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8044612

StringIndexOutOfBoundException in NativeRegExp.appendReplacement

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 9
    • Component/s: core-libs
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b17
    • CPU:
      generic
    • OS:
      generic

      Backports

        Description

        Chris Pettit wrote to nashorn-dev alias:

        ----- email --------

        Hello,

        I believe I have found a bug in NativeRegExp.appendReplacement around handling of '$'. Per [1], A '$' in newstring that does not match one of the forms in Table 22 should be left as is. The appendReplacement function handles this correctly for most cases, but breaks with the following input:

            jjs> "a".replace("a", "$")
            java.lang.StringIndexOutOfBoundsException: String index out of range: 1

        The problem is that appendReplacement assumes that a character will follow the '$' character:

                int cursor = 0;
                Object[] groups = null;

                while (cursor < replacement.length()) {
                    char nextChar = replacement.charAt(cursor);
                    if (nextChar == '$') {
                        // Skip past $
                        cursor++;
                        nextChar = replacement.charAt(cursor); // This line fails for the above input, there is no character as index 1.

        While the code should be using "$$" as a replacement text, the spec seems to indicate that "$" should work if no characters follow. I tested this with a few JS engines (node, chrome, firefox) and all handle this by replacing "a" with "$", which conforms to my reading of the spec.

        Thanks,
        Chris


        [1]: http://www.ecma-international.org/ecma-262/5.1/#sec-15.5.4.11

        ---- email ends ----

        I confirmed that the issue is reproduced with the tip of jdk8u-dev as well as jdk9 (in addition to jdk8 GA).

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                sundar Sundararajan Athijegannathan
                Reporter:
                sundar Sundararajan Athijegannathan
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved: