Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8057916

Sort includes and verify copyright for new files

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 8u40
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
      gc
    • Resolved In Build:
      b34

      Backports

        Description

        Some of the new files add by refactoring the gc code have introduced includes that are not correctly sorted. The includes should be sorted alphabetically but always with precompiled.hpp first, the other exception is that all includes guarded by defines should be placed after all other includes. For example:
        #include "precompiled.hpp"
        #include "prims/jni.h"
        #include "prims/whitebox.hpp"
        #include "utilities/debug.hpp"
        #if INCLUDE_ALL_GCS
        #include "gc_implementation/g1/g1AllocationContext.hpp"
        #include "gc_implementation/g1/g1CollectedHeap.inline.hpp"
        #include "gc_implementation/g1/heapRegion.hpp"
        #endif // INCLUDE_ALL_GCS

        Some of the new files also need to have the copyright text altered to be correct.

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                sjohanss Stefan Johansson
                Reporter:
                sjohanss Stefan Johansson
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved: