Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8073159

improve Test6857159.java

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: hotspot
    • Subcomponent:
    • Resolved In Build:
      b126

      Backports

        Description

        fix for 8068440 missed an exit code check and passing external vm flags to spawn jvm.

        On 02/04/2015 06:26 PM, Igor Ignatyev wrote:
        > On 02/02/2015 10:55 AM, Albert Noll wrote:
        >> Hi Igor,
        >>
        >> thanks for you response.
        >> On 01/29/2015 06:38 PM, Igor Ignatyev wrote:
        >>> I meant to check that exit code of spawn java process is zero.
        >>>
        >> Can I find that somewhere in the log files?
        > you can check it by OutputAnalyzer::shouldHaveExitValue(0)
        >>> also I missed that you use ProcessTools.createJavaProcessBuilder
        >>> instead of ProcessTools.executeTestJvm to spawn tested jvm. so created
        >>> jvm ignores external vm flags.
        >>>
        >> Is this ok?
        > nope, you should use ProcessTools::executeTestJvm, otherwise we'll
        > unnoticeably lose coverage.

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                iignatyev Igor Ignatyev (Inactive)
                Reporter:
                iignatyev Igor Ignatyev (Inactive)
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved: