Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8073479

Replace obj.getClass hacks with Objects.requireNonNull

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 9
    • 9
    • core-libs
    • None
    • b53

    Backports

      Description

        A few places in our class library use the weird trick of using object.getClass() to check for nullity.
        While this make seem a smart move, it actually confuses people into believing this is an approved
        practice of null checking.

        With JDK 7, we have Objects.requireNonNull that provide the proper null checking, and declare the
        intent properly. There is no performance implications of using it instead of getClass():
          http://cr.openjdk.java.net/~shade/scratch/NullChecks.java

        (Actually, there *are* a few stubborn corner cases with performance implications; see JDK-8042127.)

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8084563 Replace obj.getClass hacks with Objects.requireNonNull

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            duplicates

            Enhancement - null JDK-8025100 Use j.u.Object.requireNonNull in j.l.invoke codebase

            • P3 - Major loss of function.
            • Closed
            relates to

            Sub-task - The sub-task of the issue JDK-8130758 Replace obj.getClass with Objects.requireNonNull

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Enhancement - null JDK-8042127 Performance issues with java.util.Objects.requireNonNull

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Open

            Enhancement - null JDK-8073550 java* tools: replace obj.getClass hacks with Assert.checkNonNull or Objects.requireNonNull

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed

            Enhancement - null JDK-8073432 Object.getClass() throws stackless NPE, due to C2 intrinsic

            • P3 - Major loss of function.
            • Resolved

            Enhancement - null JDK-7041258 Use j.u.Object.requireNonNull in the JDK codebase

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed

            Activity

              People

                shade Aleksey Shipilev
                shade Aleksey Shipilev
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: