Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8138588

VerifyMergedCPBytecodes option cleanup needed

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 16
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b24
    • CPU:
      generic
    • OS:
      generic

      Description

      Dmitry noticed the following issue:

      On 9/29/15 7:26 AM, Dmitry Dmitriev wrote:
      > Hello all,
      >
      > During the work on a review of "8078556: Runtime: implement ranges (optionally constraints) for those flags that have them missing" I noticed that VerifyMergedCPBytecodes flag have following comment(hotspot/src/share/vm/runtime/globals.hpp):
      > /* change to false by default sometime after Mustang */ \
      > product(bool, VerifyMergedCPBytecodes, true, \
      > "Verify bytecodes after RedefineClasses constant pool merging") \
      >
      > Mustang is a Java 6. Just interesting: Does anyone know, is it make sense to switch this flag to "false" by default?
      >
      > Thank you,
      > Dmitry

      Our options are:

      0) remove the comment and leave VerifyMergedCPBytecodes as a
          'product' flag with its current default

      1) remove the comment, leave VerifyMergedCPBytecodes as a
          'product' flag and change the default from 'true' to 'false'

      2) remove the comment and change VerifyMergedCPBytecodes from
          a 'product' flag into a 'diagnostic' flag with its current default

      3) remove the comment, change VerifyMergedCPBytecodes from
          a 'product' flag into a 'diagnostic' flag and change the default
          from 'true' to 'false'

      4) remove the comment, leave VerifyMergedCPBytecodes as a
          product flag, make the 'release/product' build default 'false',
          and the 'non-release/non-product' build default 'true'

      5) remove the comment, change VerifyMergedCPBytecodes from
          a 'product' flag into a 'diagnostic' flag, make the 'release/product'
          build default 'false', and the 'non-release/non-product' build
          default 'true'

      6) remove the comment, remove the flag and always do the
          extra verification step.

      7) remove the comment, remove the flag and only do the extra
          verification step when built as 'non-release/non-product'.

      I think this covers all the options that we discussed in an
      internal e-mail thread.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              coleenp Coleen Phillimore
              Reporter:
              dcubed Daniel Daugherty
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: