Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8146889

Update @requires expression for GC tests to run if GC is default

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
      gc
    • Resolved In Build:
      b105

      Description

      Two hs tests use @requires as shown below:
      gc/arguments/TestObjectTenuringFlags.java: * @requires vm.gc=="Parallel"
      gc/arguments/TestInitialTenuringThreshold.java: * @requires vm.gc=="Parallel"

      such usage is not correct, because those test will not be run if no collector is specified.

      The purpose of "@requires" is to protect a test from running in not applicable configuration, such as:
      - conflicting collector
      - wrong OS
      - not enough memory
      - product/debug build

      The right expression should look like:
      @requires vm.gc=="Parallel" | vm.gc=="null"

        Attachments

          Activity

            People

            Assignee:
            dfazunen Dmitry Fazunenko (Inactive)
            Reporter:
            dfazunen Dmitry Fazunenko (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: