Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8148012

get rid of slash-dot-dot in @library directives

    XMLWordPrintable

Details

    • Enhancement
    • Status: Resolved
    • P4
    • Resolution: Fixed
    • 9
    • 9
    • hotspot
    • None
    • b106

    Description

      Jonathan Gibbons:

      ... dot-dotting out of the test directory is not good, and there's a feature in place that tests should be using instead.

      occurrences of @library /.. in hotspot/test:

      $ grep -r ' @library.* /\.\.' hotspot/test
      hotspot/test/gc/g1/TestPLABOutput.java: * @library /testlibrary /../../test/lib
      hotspot/test/compiler/types/TestMeetIncompatibleInterfaceArrays.java: * @library /testlibrary /../../test/lib
      hotspot/test/compiler/intrinsics/IntrinsicDisabledTest.java: * @library /testlibrary /../../test/lib
      hotspot/test/compiler/intrinsics/montgomerymultiply/MontgomeryMultiplyTest.java: * @library /testlibrary /../../test/lib
      hotspot/test/compiler/stable/TestStableMemoryBarrier.java: * @library /testlibrary /../../test/lib
      hotspot/test/compiler/compilercontrol/commands/PrintTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/commands/CompileOnlyTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/commands/ExcludeTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/commands/LogTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/commandfile/PrintTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/commandfile/CompileOnlyTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/commandfile/ExcludeTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/commandfile/LogTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/TestCompilerDirectivesCompatibilityCommandOff.java: * @library /testlibrary /../../test/lib
      hotspot/test/compiler/compilercontrol/directives/PrintTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/directives/CompileOnlyTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/directives/ExcludeTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/directives/LogTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/TestCompilerDirectivesCompatibilityCommandOn.java: * @library /testlibrary /../../test/lib
      hotspot/test/compiler/compilercontrol/TestCompilerDirectivesCompatibilityBase.java: * @library /testlibrary /../../test/lib
      hotspot/test/compiler/compilercontrol/TestCompilerDirectivesCompatibilityFlag.java: * @library /testlibrary /../../test/lib
      hotspot/test/compiler/compilercontrol/mixed/RandomCommandsTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/mixed/RandomValidCommandsTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/jcmd/AddCompileOnlyTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/jcmd/AddExcludeTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/jcmd/AddLogTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/jcmd/AddAndRemoveTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/compilercontrol/jcmd/AddPrintAssemblyTest.java: * @library /testlibrary /../../test/lib /compiler/testlibrary ../share /
      hotspot/test/compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java: * @library /testlibrary /../../test/lib /compiler/whitebox
      hotspot/test/compiler/cpuflags/TestAESIntrinsicsOnSupportedConfig.java: * @library /testlibrary /../../test/lib /compiler/whitebox

      Attachments

        Issue Links

          Activity

            People

              iignatyev Igor Ignatyev (Inactive)
              iignatyev Igor Ignatyev (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: