Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8149793

DirtyCardQueueSet::apply_closure_to_completed_buffer_helper isn't helpful

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
      gc
    • Resolved In Build:
      b109
    • CPU:
      generic
    • OS:
      generic

      Description

      DirtyCardQueueSet has a "helper" function apply_closure_to_completed_buffer_helper. It is only called by apply_closure_to_completed_buffer, and yet is public. And spliting up the functionality into the outer caller and the internal helper actually complicates and obfuscates what is going on. It would be better if the functionality of the helper were merged into its caller and the helper eliminated as a separate function.

        Attachments

          Activity

            People

            Assignee:
            kbarrett Kim Barrett
            Reporter:
            kbarrett Kim Barrett
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: