Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8194554

filterArguments runs multiple filters in the wrong order

    XMLWordPrintable

Details

    Backports

      Description

        If MethodHandles.filterArguments is used to apply two or more non-null filters to a method handle, those filters will be run in right-to-left order in the OpenJDK implementation. The javadoc indicates that these filters are run in normal argument order, left-to-right; IBM's implementation correctly implements this specification. If we have unit tests for this, they are probably using filter functions with no side effects, so it is impossible to detect the error.

        Suggested fix: Run the accumulation loop backwards over the array of filters. And put in a regression test with side-effecting filters.

        Links:
        http://mail.openjdk.java.net/pipermail/mlvm-dev/2018-January/006789.html
        http://mail.openjdk.java.net/pipermail/mlvm-dev/2018-January/006798.html

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8201502 filterArguments runs multiple filters in the wrong order

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8202733 filterArguments runs multiple filters in the wrong order

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8202806 filterArguments runs multiple filters in the wrong order

            • P3 - Major loss of function.
            • Resolved
            blocks

            Enhancement - null JDK-8200118 [TESTBUG] String concat tests should test toString() application order

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            csr for

            CSR - null JDK-8201371 filterArguments runs multiple filters in the wrong order

            • P3 - Major loss of function.
            • Closed

            Activity

              People

                mchung Mandy Chung
                jrose John Rose
                Votes:
                0 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: