Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8201575

Allow numbers in VERSION_PRE according to JEP 223

    XMLWordPrintable

    Details

    • Subcomponent:
    • Resolved In Build:
      b02

      Description

      ADDITIONAL SYSTEM INFORMATION :
      building with
      java version "9.0.4"
      Java(TM) SE Runtime Environment (build 9.0.4+11)
      Java HotSpot(TM) 64-Bit Server VM (build 9.0.4+11, mixed mode)


      AME="Ubuntu"
      VERSION="16.04.4 LTS (Xenial Xerus)"
      ID=ubuntu
      ID_LIKE=debian
      PRETTY_NAME="Ubuntu 16.04.4 LTS"
      VERSION_ID="16.04"
      HOME_URL="http://www.ubuntu.com/"
      SUPPORT_URL="http://help.ubuntu.com/"
      BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
      VERSION_CODENAME=xenial
      UBUNTU_CODENAME=xenial


      A DESCRIPTION OF THE PROBLEM :
      Currently the regular expression for checking the version string being set via --with-version-string=<string> in common/autoconf/jdk-version.m4 Line:89 doesn't match the jep 223 documentation.

      In the documentation the $PRE can contain numbers whereas the implementation doesn't allow numbers
      currently the regular expression is:

      ^([0-9]+)(\.([0-9]+))?(\.([0-9]+))?(\.([0-9]+))?(-([a-zA-Z]+))?((\+)([0-9]+)?(-([-a-zA-Z0-9.]+))?)?$

      to match jep 223 it should be:

      ^([0-9]+)(\.([0-9]+))?(\.([0-9]+))?(\.([0-9]+))?(-([a-zA-Z0-9]+))?((\+)([0-9]+)?(-([-a-zA-Z0-9.]+))?)?$



      STEPS TO FOLLOW TO REPRODUCE THE PROBLEM :
      have a number in the $PRE part of the version string

      EXPECTED VERSUS ACTUAL BEHAVIOR :
      EXPECTED -
      numbers in $PRE should be allowed, if they are to match jep 223
      ACTUAL -
      numbers in $PRE fails the build

      CUSTOMER SUBMITTED WORKAROUND :
      change regex in common/autoconf/jdk-version.m4 Line:89 to allow numbers in $PRE

      FREQUENCY : always


        Attachments

          Activity

            People

            Assignee:
            ihse Magnus Ihse Bursie
            Reporter:
            webbuggrp Webbug Group
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: