Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8202056

Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P3
    • 18
    • 11
    • tools
    • b21

    Description

      The core check of javac's serial lint warning (JDK-4767441) is to verify the presence of a properly declared serialVersionUID field in serializable classes.

      There are other useful checks that could be added, including that serial-involved methods are properly declared rather than being overloads which will get ignored by the serialization system. Those methods include:

       private void writeObject(java.io.ObjectOutputStream stream)
           throws IOException;
       private void readObject(java.io.ObjectInputStream stream)
           throws IOException, ClassNotFoundException;
       private void readObjectNoData()
           throws ObjectStreamException

      as discussed in java.io.ObjectInputStream and java.io.ObjectOutputStream. In additional, the serialization spec discusses the methods:

      ANY-ACCESS-MODIFIER Object writeReplace()
                   throws ObjectStreamException;
      ANY-ACCESS-MODIFIER Object readResolve()
                  throws ObjectStreamException;

      Additional methods are defined for Externalization.

      Attachments

        Issue Links

          csr for

          CSR - null JDK-8274335 Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields

          • P3 - Major loss of function.
          • Closed
          duplicates

          Enhancement - null JDK-8002086 javac should warn if serialVersionUID is present in an enum or anon subclass of an enum

          • P5 - Cosmetic problem like misspelt words or misaligned text.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8310861 Improve location reporting for javac serial lint warnings

          • P3 - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8207816 Align declaration of SerializedLambda.readResolve with serialization conventions

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8275013 Improve discussion of serialization method declarations in java.io.Object{Input, Output}Stream

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8205397 InetAddress has wrong declaration for readObjectNoData

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JDK-8207751 Remove misleading serialVersionUID from JulienFields.Field

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JDK-8208060 Additional corrections of serial-related declarations

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JDK-8209024 Use SuppressWarnings on serialVersionUID fields in interfaces

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Enhancement - null JDK-8275667 Refactor serial lint checks to be tree-based

          • P3 - Major loss of function.
          • Open

          Enhancement - null JDK-8202385 Annotation to mark serial-related fields and methods

          • P3 - Major loss of function.
          • Resolved

          Enhancement - null JDK-8203263 Remove unnecessary throws clauses from serialization-related methods

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8310835 Address gaps in -Xlint:serial checks

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-4397681 MediaTracker serialization spec refer package-protected field MediaEntry

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JDK-8241151 Incorrect lint warning for no definition of serialVersionUID in a record

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8274255 Update javac messages to use "enum class" rather than "enum type"

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8208782 Remove extra type in throws clause of SerialClob.writeObject

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Enhancement - null JDK-7019074 -Xlint serial flag could perform correctness checks on readObject/writeObject

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Enhancement - null JDK-4767441 new warning: class implements serializable but doesn't define serialVersionUID

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8160675 Issue lint warning for non-serializable non-transient instance fields in serializable type

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8229999 Apply java.io.Serial annotations to security types in java.base

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Commit Commit openjdk/jdk/6a466fe7

          Review Review openjdk/jdk/5709

          Activity

            People

              darcy Joe Darcy
              darcy Joe Darcy
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: