Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8213142

Use RAII to set the scanning source in G1ScanEvacuatedObjClosure

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 12
    • Fix Version/s: 12
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
      gc
    • Resolved In Build:
      b18

      Description

      G1ScanEvacuatedObjClosure needs to be told where the object that is scanned is located (young/old) to properly handle additions to the remembered sets.

      Currently we call a method on G1ScanEvacuatedObjClosure to do so, but it would be better to use an RAII object that automatically sets and resets it. With an additional "Uninitialized" state, basic checking whether the value has been set to find bugs can be implemented easily too.

      Suggested by ~kbarrett in the review thread for JDK-8212911.

        Attachments

          Issue Links

          is blocked by

          Enhancement - null JDK-8212911 Unify and micro-optimize handling of non-in-collection set references in oop closures

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8265409 Crash on building LineageOS with Problematic frame: # V [libjvm.so+0x6a1fe3] void G1ScanEvacuatedObjClosure::do_oop_work

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Enhancement - null JDK-8273137 Improve skipping card enqueuing during gc if there are no remembered sets in old gen

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JDK-8248892 JVM Crashed in G1ScanEvacuatedObjClosure::do_oop_work | OpenJDK build 11.0.7+10-LTS

          • P3 - Major loss of function.
          • Closed

            Activity

              People

              Assignee:
              tschatzl Thomas Schatzl
              Reporter:
              tschatzl Thomas Schatzl
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: