Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8214097

Rework thread initialization and teardown logic

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 13
    • 12
    • hotspot
    • b02

    Description

      A few cleanups to make init and tear-down clearer for both NonJavaThreads and JavaThreads. In particular:

      - Move NJT-list management to init/tear-down of the active thread, instead of constructor/destructor
      - Factor out common code across different kinds of NJTs
      - Make it easier to add init/teardown code across thread types

      Proposed approach in non-virtual call_run:

      void call_run() {
        // common init for all threads
        ...
        // virtual init
        this->pre_run();

        this_run();

        // common teardown

        // virtual teardown
        this->post_run()
        
        // Note: can't reference 'this' here as post_run may have deleted it
        ...
      }

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. JDK-8214428 Fix for JDK-8212207 was incorrect

          • P3 - Major loss of function.
          • Closed
          relates to

          Enhancement - null JDK-8215948 [TESTBUG] gtest pseudo-JavaThreads could be more regular JavaThreads

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8215954 [testbug] Remove unnecessary casts in test/hotspot/gtest/threadHelper.inline.hpp

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8212207 runtime/InternalApi/ThreadCpuTimesDeadlock.java crashes with SEGV in pthread_getcpuclockid+0x0

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8214428 Fix for JDK-8212207 was incorrect

          • P3 - Major loss of function.
          • Closed

          Enhancement - null JDK-8215097 Do not create NonJavaThreads before BarrierSet

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Review Review openjdk/jdk11u-dev/2411

          Activity

            People

              dholmes David Holmes
              dholmes David Holmes
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: