Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8214230

Classes generated by SystemModulesPlugin.java are not reproducable

    XMLWordPrintable

Details

    • b23
    • generic
    • generic
    • Verified

    Backports

      Description

        The classes generated by src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java (jdk.internal.module.SystemModules$default.class and jdk.internal.module.SystemModules$all.class) are not reproducable between builds. This is because SystemModulesPlugin iterates over various sets (exports, requires, providers, opens, etc.) and the iteration over Set is unspecified. The iteration order do differ between builds (most likely because some of the Sets are HashSets), so the generated classes differ between builds.

        I have attached a reproducer, reproducer.zip, that can be used to show the issue. Just unzip the file and run "sh reproduce.sh" (use --verbose if you want a diff).

        I have also attached a patch that fixes this issue by sorting the collections prior to iterating over them.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8258685 Classes generated by SystemModulesPlugin.java are not reproducable

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8259588 Classes generated by SystemModulesPlugin.java are not reproducable

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            duplicates

            Bug - A problem which impairs or prevents the functions of the product. JDK-8172167 Consider making jlink module iteration order stable

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8232864 Classes generated at link time by GenerateJLIClassesPlugin are not reproducible

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8258945 test/jdk/tools/jlink/JLinkReproducibleTest.java fails randomly when cds is disabled

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed

            Activity

              People

                ehelin Erik Helin
                ehelin Erik Helin
                Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: