Description
Webrev at http://cr.openjdk.java.net/~herrick/8221582/ indicated that not just public interfaces were affected with the rename. However not all tokens containing "jvm" substring was touched.
It would make sense to at least replace JVMArgs with JavaArgs substring:
---
ASEMENYU-LAP+asemenyu@ASEMENYU-LAP /cygdrive/c/ade/work/as/jds/work/10_sandbox/jdk10/open/src/jdk.jpackage
$ find . -name '*.cpp' -o -name '*.h' | xargs.exe grep JVMArgs
./share/native/libapplauncher/Helpers.cpp: Helpers::GetJVMArgsFromConfig(IPropertyContainer* config) {
./share/native/libapplauncher/Helpers.cpp: OrderedMap<TString, TString> JVMArgs =
./share/native/libapplauncher/Helpers.cpp: Helpers::GetJVMArgsFromConfig(&propertyFile);
./share/native/libapplauncher/Helpers.cpp: Container->AppendSection(keys[CONFIG_SECTION_JVMOPTIONS], JVMArgs);
./share/native/libapplauncher/Helpers.h: GetJVMArgsFromConfig(IPropertyContainer* config);
./share/native/libapplauncher/JavaVirtualMachine.cpp: options.AppendValues(package.GetJVMArgs());
./share/native/libapplauncher/Package.cpp: ReadJVMArgs(config);
./share/native/libapplauncher/Package.cpp:void Package::ReadJVMArgs(ISectionalPropertyContainer* Config) {
./share/native/libapplauncher/Package.cpp: FBootFields->FJVMArgs);
./share/native/libapplauncher/Package.cpp: FBootFields->FJVMArgs);
./share/native/libapplauncher/Package.cpp: FBootFields->FJVMArgs);
./share/native/libapplauncher/Package.cpp:OrderedMap<TString, TString> Package::GetJVMArgs() {
./share/native/libapplauncher/Package.cpp: return FBootFields->FJVMArgs;
./share/native/libapplauncher/Package.h: OrderedMap<TString, TString> FJVMArgs;
./share/native/libapplauncher/Package.h: void ReadJVMArgs(ISectionalPropertyContainer* Config);
./share/native/libapplauncher/Package.h: OrderedMap<TString, TString> GetJVMArgs();
---
Attachments
Issue Links
- relates to
-
JDK-8221582 Rename jvm-args option to java-options
- Resolved