Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8229145

Revert TemplateTable::bytecode() visibility change

    XMLWordPrintable

Details

    • Enhancement
    • Status: Resolved
    • P4
    • Resolution: Fixed
    • 8-aarch64
    • 8-aarch64
    • hotspot
    • None

    Backports

      Description

        In current 8u-aarch64 code, TemplateTable::bytecode() is public:

        public:
           static Bytecodes::Code bytecode() { return _desc->bytecode(); }
         
        private:
          static BarrierSet* _bs; // Cache the barrier set.

        This is 8u-aarch64-specific thing, though, and 8u upstream still has it private. It seem to be added to support simulator hack in Template::generate:
        https://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/hotspot/rev/38b753943a54#l14.1

        It would go away with Simulator removal. But even before that, Template and TemplateTable are friends, so this hack is not needed. This change should be reverted.

        Attachments

          Issue Links

            Activity

              People

                shade Aleksey Shipilev
                shade Aleksey Shipilev
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: