Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8241768

git needs .gitattributes

    XMLWordPrintable

Details

    • b15
    • generic
    • windows

    Backports

      Description

        git has a idiosyncrasy in that when using git clone on Windows machines it forces adding CR-LF line terminations by default on Windows.

        This causes a host of problems:
        1 newer version of Cygwin bash will fail as follows:
        configure: line 24: $'\r': command not found
        configure: line 27: $'\r': command not found
        configure: line 30: cd: $'.\r': No such file or directory
         configure: line 31: $'\r': command not found

        2. This is likely to cause issues when folks generate webrevs or diffs.

        The solution, we need to add .gitattributes at the top of the repository as described below:
        https://help.github.com/en/github/using-git/configuring-git-to-handle-line-endings

        Using Cygwin's git does not exhibit the above problem.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8271604 git needs .gitattributes

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8278244 git needs .gitattributes

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8280756 git needs .gitattributes

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8281141 git needs .gitattributes

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8293277 git needs .gitattributes

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8267892 Add .gitattributes to repo

            • P3 - Major loss of function.
            • Resolved
            links to

            Commit Commit openjdk/jdk11u-dev/37bc75b3

            Commit Commit openjdk/shenandoah-jdk8u/6305c6ff

            Review Review openjdk/jdk11u-dev/176

            Review Review openjdk/shenandoah-jdk8u/3

            Activity

              People

                ihse Magnus Ihse Bursie
                ksrini Kumar Srinivasan
                Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: