Details
-
Type:
Bug
-
Status: Resolved
-
Priority:
P4
-
Resolution: Fixed
-
Affects Version/s: 11
-
Fix Version/s: 16
-
Component/s: infrastructure
-
Subcomponent:
-
Resolved In Build:b15
-
CPU:generic
-
OS:windows
Backports
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8271604 | 11.0.13 | Christoph Langer | P4 | Resolved | Fixed | b01 |
JDK-8278244 | openjdk8u332 | Severin Gehwolf | P4 | Resolved | Fixed | b01 |
JDK-8280756 | 8u321 | Erik Joelsson | P4 | Resolved | Fixed | b33 |
JDK-8281141 | na | Christoph Langer | P4 | Resolved | Duplicate |
Description
git has a idiosyncrasy in that when using git clone on Windows machines it forces adding CR-LF line terminations by default on Windows.
This causes a host of problems:
1 newer version of Cygwin bash will fail as follows:
configure: line 24: $'\r': command not found
configure: line 27: $'\r': command not found
configure: line 30: cd: $'.\r': No such file or directory
configure: line 31: $'\r': command not found
2. This is likely to cause issues when folks generate webrevs or diffs.
The solution, we need to add .gitattributes at the top of the repository as described below:
https://help.github.com/en/github/using-git/configuring-git-to-handle-line-endings
Using Cygwin's git does not exhibit the above problem.
This causes a host of problems:
1 newer version of Cygwin bash will fail as follows:
configure: line 24: $'\r': command not found
configure: line 27: $'\r': command not found
configure: line 30: cd: $'.\r': No such file or directory
configure: line 31: $'\r': command not found
2. This is likely to cause issues when folks generate webrevs or diffs.
The solution, we need to add .gitattributes at the top of the repository as described below:
https://help.github.com/en/github/using-git/configuring-git-to-handle-line-endings
Using Cygwin's git does not exhibit the above problem.
Attachments
Issue Links
- backported by
-
JDK-8271604 git needs .gitattributes
-
- Resolved
-
-
JDK-8278244 git needs .gitattributes
-
- Resolved
-
-
JDK-8280756 git needs .gitattributes
-
- Resolved
-
-
JDK-8281141 git needs .gitattributes
-
- Resolved
-
- relates to
-
JDK-8267892 Add .gitattributes to repo
-
- Resolved
-
- links to
-
Commit openjdk/jdk11u-dev/37bc75b3
-
Review openjdk/jdk11u-dev/176
-
Review openjdk/shenandoah-jdk8u/3
(3 links to)