Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8248701

On Windows generated modules-deps.gmk can contain backslash-r (CR) characters

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 11, 14, 15, 16
    • Fix Version/s: 16
    • Component/s: infrastructure
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b05
    • OS:
      windows

      Description

      modules-deps.gmk is generated by Modules.gmk by filtering all the module-info.java files. However, if a module-info.java happens to contain \r(CR) character on Windows the filtered module name ends up with a CR on the end causing an invalid dependency build break on Windows.

      Reproduce:
      On Windows edit src/java.rmi/share/classes/module-info.java and
      insert a CR at the end of line "requires java.logging;"
      Build... will produce error like:
      08:31:04 + make all
      08:31:30 Building target 'all' in configuration 'windows-x86_64-server-release'
      08:31:30 Compiling 8 files for BUILD_TOOLS_LANGTOOLS
      08:31:30 make[2]: *** No rule to make target 'java.logging

        Attachments

          Activity

            People

            Assignee:
            aleonard Andrew Leonard
            Reporter:
            aleonard Andrew Leonard
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: