Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8250636

iso8601_time returns incorrect offset part on MacOS

    XMLWordPrintable

Details

    • b11

    Backports

      Description

        The problem is in the get_timezone function.

        src/hotspot/share/runtime/os.cpp

        static time_t get_timezone(const struct tm* time_struct) {
        #if defined(_ALLBSD_SOURCE)
          return time_struct->tm_gmtoff;
        #elif defined(_WINDOWS)
          long zone;
          _get_timezone(&zone);
          return static_cast<time_t>(zone);
        #else
          return timezone;
        #endif
        }

        The call to get_timezone works fine on Mac but it returns undeclared "timezone" on Linux.

        According to the doc for the tm_gmtoff member:
        “The tm_gmtoff field is derived from BSD and is a GNU library extension; it is not visible in a strict ISO C environment.”

        It might make sense to return time_struct->tm_gmtof if _GNU_SOURCE is defined. Attached a candidate patch.

        Attachments

          1. get_timezone_v2.patch
            0.4 kB
          2. get_timezone_v2.patch
            2 kB
          3. get_timezone_v3.patch
            2 kB
          4. get_timezone.patch
            0.4 kB

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8257134 iso8601_time returns incorrect offset part on MacOS

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8257472 iso8601_time returns incorrect offset part on MacOS

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8257900 iso8601_time returns incorrect offset part on MacOS

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8258087 iso8601_time returns incorrect offset part on MacOS

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8251365 Build failure on AIX after 8250636

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved
            links to

            Commit Commit openjdk/jdk13u-dev/cf0e9356

            Review Review openjdk/jdk13u-dev/51

            Review Review openjdk/jdk13u-dev/52

            Activity

              People

                dcherepanov Dmitry Cherepanov
                dcherepanov Dmitry Cherepanov
                Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: