Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8253402

Convert vmSymbols::SID to enum class

    XMLWordPrintable

Details

    • b21

    Description

      Convert vmSymbols::SID to enum class to provide better type safety.

      Also implement proper enumerators for this type of enums to avoid code like this (which might get out of bounds if you're not careful):

          for (int index = (int)FIRST_SID; index < (int)SID_LIMIT; index++) {
            vm_symbol_index[index] = (SID)index;
          }

      The new iteration style is:

          for (vmSymbolID index : vmSymbolsIterator()) {
            vm_symbol_index[as_int(index)] = index;
          }


      Also, implement type-safe casting from ints to SIDs, and vice versa.

      Attachments

        Issue Links

          relates to

          Enhancement - null JDK-8243066 move VM_INTRINSICS_DO into its own vmIntrinsics.hpp file

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8247938 Change various JVM enums like LinkInfo::AccessCheck and Klass::DefaultsLookupMode to enum class

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8256254 Convert vmIntrinsics::ID to enum class

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8254733 HotSpot Style Guide should permit using range-based for loops

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8257912 Convert enum iteration to use range-based for loops

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Commit Commit openjdk/jdk/7e5eb493

          Review Review openjdk/jdk/276

          Activity

            People

              iklam Ioi Lam
              iklam Ioi Lam
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: