Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8254335

logging/logStream.hpp includes memory/resourceArea.hpp but doesn't need it

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 16
    • Fix Version/s: 16
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b20
    • CPU:
      generic
    • OS:
      generic

      Description

      While cleaning up the logging in Erik's new code for:

          JDK-8253064 monitor list simplifications and getting rid of TSM

      I noticed that logging/logStream.hpp includes memory/resourceArea.hpp
      but doesn't need it.

      That include was added to logging/logStream.hpp by:

          JDK-8153659 Create a CHeap backed LogStream class

      but logging/logStream.hpp has since evolved to no longer
      use ResourceMarks in the header file. Looks like that work
      was done via:

          JDK-8181917: Refactor UL LogStreams to avoid using resource area

      Of course, removing the include of memory/resourceArea.hpp reveals
      other code that uses ResourceMark(s), but never bothered to include
      memory/resourceArea.hpp.

      I created this issue to pull on the sweater threads in order
      to clean this up.

      Update: It was a sub-task of JDK-8253064, but, after thinking about it,
      I think it makes more sense as a standalone issue.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dcubed Daniel Daugherty
              Reporter:
              dcubed Daniel Daugherty
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: