Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8256950

Add record attribute support to symbol generator CreateSymbols

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 16
    • Fix Version/s: 16
    • Component/s: tools
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b28

      Description

      When prototyping adding a new public API type, that is a record class, to the JDK it is clear that the symbolgenerator CreateSymbols does not expect or handle the record attribute.

      This is most evident from the failure of test/langtools/tools/javac/platform/CanHandleClassFilesTest.java

      Additionally, javac generates a MethodParameters for the canonical constructor of a record class. This also trips up the symbol generator. The MethodParameters should likely just be ignored/skipped.

      ----------System.err:(25/1772)----------
      java.lang.reflect.InvocationTargetException
      at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64)
      at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.base/java.lang.reflect.Method.invoke(Method.java:564)
      at CanHandleClassFilesTest.run(CanHandleClassFilesTest.java:117)
      at CanHandleClassFilesTest.main(CanHandleClassFilesTest.java:53)
      at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64)
      at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.base/java.lang.reflect.Method.invoke(Method.java:564)
      at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:298)
      at java.base/java.lang.Thread.run(Thread.java:831)
      Caused by: java.lang.IllegalStateException: Unhandled attribute: Record
      at build.tools.symbolgenerator.CreateSymbols.readAttribute(CreateSymbols.java:2157)
      at build.tools.symbolgenerator.CreateSymbols.inspectClassFile(CreateSymbols.java:1836)
      at build.tools.symbolgenerator.CreateSymbols.loadVersionClasses(CreateSymbols.java:1390)
      at build.tools.symbolgenerator.CreateSymbols.incrementalUpdate(CreateSymbols.java:1698)
      at build.tools.symbolgenerator.CreateSymbols.createIncrementalBaseLine(CreateSymbols.java:1761)
      at build.tools.symbolgenerator.CreateSymbols.main(CreateSymbols.java:3942)
      ... 12 more

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jlahoda Jan Lahoda
              Reporter:
              chegar Chris Hegarty
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: