Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8260046

Assert left >= right in pointer_delta() methods

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 17
    • 17
    • hotspot
    • None
    • gc
    • b23

    Description

      During the investigation for JDK-8259271 we found that the compiler (rightfully) reordered some loads that were written concurrently that caused crashes.

      An assert in the pointer_delta() methods would have caught that unintentional reordering. pointer_delta() implicitly assumes left >= right, since the point of it is to use unsigned arithmetic to be able to deal with large memory ranges that exceed the range of ptrdiff_t.


      Investigate adding an assert in pointer_delta (and see what else crashes).

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8267579 Thread::cooked_allocated_bytes() hits assert(left >= right) failed: avoid underflow

          • P3 - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8267213 cpuinfo_segv is incorrectly triaged as execution protection violation on x86_32

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8268334 Reconsider Thread::cooked_allocated_bytes()

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JDK-8268265 MutableSpaceUsedHelper::take_sample() hits assert(left >= right) failed: avoid overflow

          • P3 - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8259271 gc/parallel/TestDynShrinkHeap.java still fails "assert(covered_region.contains(new_memregion)) failed: new region is not in covered_region"

          • P2 - Crashes, loss of data, severe memory leak.
          • Closed
          links to

          Commit Commit openjdk/jdk/360928d1

          Review Review openjdk/jdk/3900

          Activity

            People

              ayang Albert Yang
              tschatzl Thomas Schatzl
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: