Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8267138

Stray suffix when starting gtests via GTestWrapper.java

    XMLWordPrintable

Details

    • b04

    Backports

      Description

        For JDK-8185734: "[Windows] Structured Exception Catcher missing around gtest execution", I specified that --gtest_catch_exceptions=0 should be specified to leave signal handling to the VM. This was needed to prevent the gtest runner from catching the stack-based SEH exceptions bubbling up from the tested VM, and leave them to our upstairs gtest runner wrapper to catch.

        However, there is a typo:
        ```
        --gtest_catch_exceptions=0test_result.xml
        ```

        Unless I am mistaken, it did not seem to have impeded Windows gtests. So maybe the gtest runner does a prefix match only. But this should be fixed.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8295983 Stray suffix when starting gtests via GTestWrapper.java

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8296047 Stray suffix when starting gtests via GTestWrapper.java

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8185734 [Windows] Structured Exception Catcher missing around gtest execution

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Enhancement - null JDK-8264408 test_oopStorage no longer needs to disable some tests on WIN32

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk17u-dev/f65bf068

            Commit Commit openjdk/jdk/b565459f

            Review Review openjdk/jdk17u-dev/822

            Review Review openjdk/jdk/4025

            Activity

              People

                stuefe Thomas Stuefe
                stuefe Thomas Stuefe
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: