Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8274130

C2: MulNode::Ideal chained transformations may act on wrong nodes

    XMLWordPrintable

Details

    • b17

    Backports

      Description

        I was puzzled by it when fixing JDK-8274060. It looks that new optimizations added by JDK-8273454 and JDK-8263006 rewire in(1) and in(2) in MulNode::Ideal, which means the chained transformations should see them? Yet, both inputs and their Type-s are cached locally and not refreshed. I have not seen failures due to this yet, but it looks that the current code is subtly incorrect because of this.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8279373 C2: MulNode::Ideal chained transformations may act on wrong nodes

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8298922 C2: MulNode::Ideal chained transformations may act on wrong nodes

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Enhancement - null JDK-8263006 Add optimization for Max(*)Node and Min(*)Node

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Enhancement - null JDK-8273454 C2: Transform (-a)*(-b) into a*b

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk17u-dev/256356d4

            Commit Commit openjdk/jdk/756d22c3

            Review Review openjdk/jdk17u-dev/25

            Review Review openjdk/jdk/5631

            Activity

              People

                shade Aleksey Shipilev
                shade Aleksey Shipilev
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: