Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8278207

G1: Tighten verification in G1ResetSkipCompactingClosure

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 18
    • Fix Version/s: 19
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
      gc
    • Resolved In Build:
      b05

      Description

      `G1FullGCPrepareTask::G1CalculatePointersClosure::do_heap_region` contains the following structure:

      ```
      if (is_humongous) {
      } else if (is_open_archive()) {
      } else if (is_closed_archive()) {
      } else {
      }
      ```

      The verification in `G1ResetSkipCompactingClosure` basically checks whether skip-compacting regions actually meet the criteria to skip compaction.

      To make the code more straightforward, it should mirror the original structure as well, instead of a single assert.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ayang Albert Yang
              Reporter:
              ayang Albert Yang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: