Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8279533

Bad indentation and missing curly braces in BlockBegin::set_end

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 18, 19
    • Fix Version/s: 19
    • Component/s: hotspot
    • Subcomponent:
    • Resolved In Build:
      b05

      Description

      SonarClound reports indentation problem near "if (_end != NULL)". It is also not entirely clear if that block misses `_end = NULL`, like the original code had before JDK-8277496.

      void BlockBegin::set_end(BlockEnd* new_end) { // Assumes that no predecessor of new_end still has it as its successor
        ...
        // Remove this block as predecessor of its current successors
        if (_end != NULL)
        for (int i = 0; i < number_of_sux(); i++) {
          sux_at(i)->remove_predecessor(this);
        }

      Ludvig, please take a look?

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              lujaniuk Ludvig Janiuk
              Reporter:
              shade Aleksey Shipilev
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: