Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8280568

IGV: Phi inputs and pinned nodes are not scheduled correctly

    XMLWordPrintable

Details

    • b21

    Description

      Nodes aren't shown in correct blocks, even if they have explicit control. In attached image all nodes encircled should be drawn in other blocks, for two reasons: pinned nodes should be scheduled in the same block as the nodes they are pinned to, and phi inputs should be scheduled above the block in which the phi node is scheduled.

      To reproduce the issue shown in the picture, open the graph file alloc.xml (included in the attached ZIP bundle), open the graph "Optimize finished", and open the mode "Cluster nodes into blocks". The graph file itself is generated by compiling the simple program SimpleAlloc.java (also included in the attached ZIP bundle) with JDK 17 as follows:

      $ java -XX:+PrintOpto -XX:CompileCommand=IGVPrintLevel,SimpleAlloc::testAllocArray,4 -XX:CompileCommand=compileonly,*::testAllocArray -XX:PrintIdealGraphFile=alloc.xml SimpleAlloc.java

      Attachments

        2. alloc.png
          332 kB
          Nils Eliasson

        Issue Links

          blocks

          Enhancement - null JDK-8282053 IGV: refine schedule approximation

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Enhancement - null JDK-8273666 Improve IdealGraphVisualizer tool

          • P3 - Major loss of function.
          • Resolved
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. JDK-8281539 IGV: schedule approximation computes immediate dominators wrongly

          • P3 - Major loss of function.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8287438 IGV: scheduling crashes on non-block-start Region with multiple predecessors

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8287164 IGV: NPE in InputBlock::addNode()

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Commit Commit openjdk/jdk/7a483517

          Review Review openjdk/jdk/7493

          Activity

            People

              rcastanedalo Roberto Castaneda Lozano
              neliasso Nils Eliasson (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: