Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8282887

Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

    XMLWordPrintable

Details

    Backports

      Description

        File: java.base/windows/native/libjava/HostLocaleProviderAdapter_md.c

        The native method: Java_sun_util_locale_provider_HostLocaleProviderAdapterImpl_getNumberPattern(...) {

        ...
            langtag = (*env)->GetStringChars(env, jlangtag, JNI_FALSE);
            CHECK_NULL_RETURN(langtag, NULL);
            pattern = getNumberPattern(langtag, numberStyle);
            CHECK_NULL_RETURN(pattern, NULL);

            (*env)->ReleaseStringChars(env, jlangtag, langtag);
        ...
        }

        If getNumberPattern() call returns NULL, langtag is not released.

        Also, the call GetStringChars(env, jlangtag, JNI_FALSE) looks weird, as the last parameter should be a pointer to jboolean, not a jboolean. It works due to JNI_FALSE == 0 (or NULL).

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8284217 Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8284218 Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8284235 Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk11u-dev/2f1bee61

            Commit Commit openjdk/jdk17u-dev/e8db3465

            Commit Commit openjdk/jdk18u/8f4dbe59

            Commit Commit openjdk/jdk/2cddf3f5

            Review Review openjdk/jdk11u-dev/965

            Review Review openjdk/jdk17u-dev/317

            Review Review openjdk/jdk18u/86

            Review Review openjdk/jdk/7777

            Activity

              People

                zgu Zhengyu Gu
                zgu Zhengyu Gu
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: