Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8287396

LIR_Opr::vreg_number() and data() can return negative number

    XMLWordPrintable

Details

    • b26

    Backports

      Description

        This code seems wrong:

        uintptr_t data() const { return value() >> data_shift; }

        It's doing a signed shift, so the sign bit is going to be extended into the unsigned result, giving a value that is too large.

        In JDK-8261235, non_data_bits was changed to work around this problem, but the real problem is the sign bit. non_data_bits should not count pointer_bits because pointer_bits is actually included in kind_bits (see JDK-8287288).

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8288830 LIR_Opr::vreg_number() and data() can return negative number

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8289453 LIR_Opr::vreg_number() and data() can return negative number

            • P3 - Major loss of function.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8261235 C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check

            • P3 - Major loss of function.
            • Resolved

            Enhancement - null JDK-8287288 Fix some typos in C1

            • P5 - Cosmetic problem like misspelt words or misaligned text.
            • Resolved
            links to

            Commit Commit openjdk/jdk17u-dev/201dad41

            Commit Commit openjdk/jdk/cdb47688

            Review Review openjdk/jdk17u-dev/502

            Review Review openjdk/jdk/8912

            Activity

              People

                dlong Dean Long
                dlong Dean Long
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: