Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-1019

IssueNotifier fails if there are extra branches in a repo

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 0.9
    • Fix Version/s: 0.9
    • Component/s: bots
    • Labels:
      None

      Description

      IssueNotifier.onNewOpenJDKTagCommits() fails when a tag is created in a repo where there are extra branches without configured fixVersions. It tries to look through every branch that contain each commit and update the corresponding backport, but if it finds a branch for which there is no fixVersion defined, it can't find the backport and quits, leaving any still unprocessed commits in the dust.

      I think we need to accept that there may be branches existing for which we don't want JBS notifications, and that is simply signaled by not configuring the fixVersion for those branches.

      I tried to simply configure a fixVersion for the branch in question that triggered this just now, but then we hit another problem when there is no backport record for that branch. This again should in my opinion be ok. If we never created a backport record for this version, then we just shouldn't update it. There could be a risk for a race if we allow this though, if the creation of the backport was somehow delayed, but I think we will just have to accept that possibility.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              erikj Erik Joelsson
              Reporter:
              erikj Erik Joelsson
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: