Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-218

Enforce check on approval of CSRs

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9
    • Component/s: bots
    • Labels:
      None

      Description

      As a conclusion of the discussion we had on the OpenJFX-dev mailing list [1], it was suggested that the bot be aware of the requirement and state of a CSR.

      This can be done with a `/csr` command invoked by a Reviewer (or perhaps a Committer is enough). The bot will then require linking a CSR. A few of ideas as to how to do it:
      1. The author has to specify an issue number or a link to the CSR, similar to how it is done for the main issue in the title.
      2. The bot can check for a "csr" issue link in the main issue in JBS.
      3. The author can reply with a comment pointing to the CSR.

      Option 2 seems the most robust since it doesn't require extra interaction. The bot will add the CSR issue link under "Issue" similar to how it is done for the main issue.

      As part of the integration validity check, the bot will check if the CSR was closed as approved. A checkbox for it can be added under Progress.

      [1] http://mail.openjdk.java.net/pipermail/openjfx-dev/2019-December/024323.html

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ehelin Erik Helin
              Reporter:
              nlisker Nir Lisker
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: