Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-295

jcheck should always use configuration from the target branch

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9
    • Component/s: bots
    • Labels:
      None

      Description

      This is a follow-on to SKARA-118. In some cases when the Skara bot runs jcheck, it uses the configuration from the PR rather than the one from the target branch.

      For example: https://github.com/openjdk/lanai/pull/1

      This PR should have required a reviewer, since the .jcheck/conf file in the target branch (master) at the time of the PR was set to use the legacy jdk configuration. However, the bot marked the PR as ready to integrate without any reviewer.

        Attachments

          Issue Links

          relates to

          Enhancement - null SKARA-118 Use jcheck configuration from PR target branch

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link Commit openjdk/skara/9fe63b93

          Web Link Review openjdk/skara/491

            Activity

              People

              Assignee:
              ehelin Erik Helin
              Reporter:
              kcr Kevin Rushforth
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: