Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-437

Skara should invalidate approved reviews if the target branch changes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9
    • Component/s: bots
    • Labels:
      None

      Description

      A project can be configured to invalidate an approved review on a PR if a new commit is pushed. This has the effect of requiring a re-review from all reviewers in order for their approval to count.

      Similarly, a change to the target branch should invalidate all approved reviews. This case is at least as important to flag as a new commit pushed to the source branch.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rwestberg Robin Westberg (Inactive)
              Reporter:
              kcr Kevin Rushforth
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: