Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-690

Merge commit message is not Merge jdk, but: Merge jdk

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P3 P3
    • 0.9
    • None
    • bots
    • None

      https://github.com/openjdk/valhalla/pull/192

      Clearly I started out confused, that the PR title and summary is the resulting commit message, so I didn't care too much for actual merge commit in my fork, mistakes were made...

      Attempted local jcheck before "pr create", no matter what ".jcheck/conf" contained it complained about every single label, even with "[repository]" section removed...fine, give up and ignore jcheck, "pr create" without jcheck

      The merge commit was message was default, i.e. "Merge tag 'jdk-16+16' into lworld_merge_jdk_16_16", but the merge itself updated ".jcheck/conf" with merge message rule, which was tweaked to "Merge jdk"

      The PR then report merge commit error, so I removed "merge" from the list of errors in .jcheck/conf.

      The PR now shows "Merge commit message is not Merge jdk, but: Merge jdk"

      Attempted to change the conf to ".*", the bot doesn't appear to be using my pushed ".jcheck/conf"

      Stuck with "Merge commit message is not Merge jdk, but: Merge jdk"

            rwestberg Robin Westberg (Inactive)
            dsimms David Simms
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: