Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-930

Skara bot adds confusing comment to PR when CSR is needed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9
    • Component/s: bots
    • Labels:
      None

      Description

      Skara adds the following comment to a PR when processing the "/csr needed" command:

      <USERNAME>: please create a CSR request and add link to it in JDK-nnnnnnn. This pull request cannot be integrated until the CSR request is approved.

      This is a confusing comment, suggesting that there is some additional action needed to "add link" beyond creating the CSR. This is not the case, since creating a CSR from the bug does all of the necessary linking.

      See this comment for an example of the confusion it created:

      https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075486.html

      I suggest rewording this to something like:

      <USERNAME>: please create a CSR request for JDK-nnnnnnn. This pull request cannot be integrated until the CSR request is approved.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ehelin Erik Helin
              Reporter:
              kcr Kevin Rushforth
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: