# HG changeset patch # Parent 4c3674e9ab579fafdb043ed3462d0e6352f9c0f1 RT-38480: [CSS] ProgressIndicator does not spin anymore since 8u20 diff -r 4c3674e9ab57 apps/toys/Hello/src/main/java/hello/HelloProgressIndicator.java --- a/apps/toys/Hello/src/main/java/hello/HelloProgressIndicator.java Fri Aug 29 09:37:30 2014 -0400 +++ b/apps/toys/Hello/src/main/java/hello/HelloProgressIndicator.java Fri Aug 29 10:18:16 2014 -0400 @@ -112,17 +112,16 @@ pInd6.setProgress(0.5); root.getChildren().add(pInd6); + // busy indicator - indeterminate and spin are enabled by default + // See https://wiki.openjdk.java.net/display/OpenJFX/ProgressIndicator+User+Experience+Documentation ProgressIndicator pInd7 = new ProgressIndicator(); pInd7.setLayoutX(300); pInd7.setLayoutY(250); - pInd7.setProgress(-1); - pInd7.setStyle("-fx-spin-enabled:true;"); root.getChildren().add(pInd7); ProgressIndicator pInd8 = new ProgressIndicator(); pInd8.setLayoutX(360); pInd8.setLayoutY(250); - pInd8.setProgress(-1); pInd8.setStyle("-fx-spin-enabled:false;"); root.getChildren().add(pInd8); diff -r 4c3674e9ab57 modules/controls/src/main/java/com/sun/javafx/scene/control/skin/ProgressIndicatorSkin.java --- a/modules/controls/src/main/java/com/sun/javafx/scene/control/skin/ProgressIndicatorSkin.java Fri Aug 29 09:37:30 2014 -0400 +++ b/modules/controls/src/main/java/com/sun/javafx/scene/control/skin/ProgressIndicatorSkin.java Fri Aug 29 10:18:16 2014 -0400 @@ -134,7 +134,7 @@ /** * True if the progress indicator should rotate as well as animate opacity. */ - private final BooleanProperty spinEnabled = new StyleableBooleanProperty(false) { + private final BooleanProperty spinEnabled = new StyleableBooleanProperty(true) { @Override protected void invalidated() { if (spinner!=null) spinner.setSpinEnabled(get()); } @@ -531,7 +531,7 @@ private final class IndeterminateSpinner extends Region { private IndicatorPaths pathsG; private final List opacities = new ArrayList<>(); - private boolean spinEnabled = false; + private boolean spinEnabled = true; private Paint fillOverride = null; private IndeterminateSpinner(boolean spinEnabled, Paint fillOverride) { @@ -730,7 +730,7 @@ } }; private static final CssMetaData SPIN_ENABLED = - new CssMetaData("-fx-spin-enabled", BooleanConverter.getInstance(), Boolean.FALSE) { + new CssMetaData("-fx-spin-enabled", BooleanConverter.getInstance(), Boolean.TRUE) { @Override public boolean isSettable(ProgressIndicator node) { final ProgressIndicatorSkin skin = (ProgressIndicatorSkin) node.getSkin();