## Code Review for open

Prepared by: | smarks on Tue Nov 28 17:14:51 PST 2017
Workspace: | /Users/src/jdk-dev/jdk10-closed/open
Compare against version: | qparent
Summary of changes: | 689 lines changed: 537 ins; 13 del; 139 mod; 13803 unchg
Patch of changes: | open.patch
Legend: | Modified file Deleted file New file

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/java.base/share/classes/java/util/Collection.java

>     rev 47953 : 8177290: add copy factory methods for unmodifiable List, Set, Map
>     8184690: add Collectors for collecting into unmodifiable List, Set, and Map
>     Reviewed-by: alanb, briangoetz, dholmes, jrose, rriggs, scolebourne

> 93 lines changed: 80 ins; 4 del; 9 mod; 591 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/java.base/share/classes/java/util/Collections.java

>     rev 47953 : 8177290: add copy factory methods for unmodifiable List, Set, Map
>     8184690: add Collectors for collecting into unmodifiable List, Set, and Map
>     Reviewed-by: alanb, briangoetz, dholmes, jrose, rriggs, scolebourne

> 24 lines changed: 0 ins; 8 del; 16 mod; 5575 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/java.base/share/classes/java/util/List.java

>     rev 47953 : 8177290: add copy factory methods for unmodifiable List, Set, Map
>     8184690: add Collectors for collecting into unmodifiable List, Set, and Map
>     Reviewed-by: alanb, briangoetz, dholmes, jrose, rriggs, scolebourne

> 56 lines changed: 26 ins; 0 del; 30 mod; 1012 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/java.base/share/classes/java/util/Map.java

>     rev 47953 : 8177290: add copy factory methods for unmodifiable List, Set, Map
>     8184690: add Collectors for collecting into unmodifiable List, Set, and Map
>     Reviewed-by: alanb, briangoetz, dholmes, jrose, rriggs, scolebourne

> 63 lines changed: 29 ins; 0 del; 34 mod; 1624 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/java.base/share/classes/java/util/Set.java

>     rev 47953 : 8177290: add copy factory methods for unmodifiable List, Set, Map
>     8184690: add Collectors for collecting into unmodifiable List, Set, and Map
>     Reviewed-by: alanb, briangoetz, dholmes, jrose, rriggs, scolebourne

> 57 lines changed: 27 ins; 0 del; 30 mod; 673 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` src/java.base/share/classes/java/util/stream/Collectors.java

>     rev 47953 : 8177290: add copy factory methods for unmodifiable List, Set, Map
>     8184690: add Collectors for collecting into unmodifiable List, Set, and Map
>     Reviewed-by: alanb, briangoetz, dholmes, jrose, rriggs, scolebourne

> 140 lines changed: 138 ins; 0 del; 2 mod; 1780 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` test/jdk/java/util/Collection/MOAT.java

>     rev 47953 : 8177290: add copy factory methods for unmodifiable List, Set, Map
>     8184690: add Collectors for collecting into unmodifiable List, Set, and Map
>     Reviewed-by: alanb, briangoetz, dholmes, jrose, rriggs, scolebourne

> 55 lines changed: 54 ins; 0 del; 1 mod; 1636 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` test/jdk/java/util/Collection/SetFactories.java

>     rev 47953 : 8177290: add copy factory methods for unmodifiable List, Set, Map
>     8184690: add Collectors for collecting into unmodifiable List, Set, and Map
>     Reviewed-by: alanb, briangoetz, dholmes, jrose, rriggs, scolebourne

> 55 lines changed: 52 ins; 0 del; 3 mod; 285 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` test/jdk/java/util/List/ListFactories.java

>     rev 47953 : 8177290: add copy factory methods for unmodifiable List, Set, Map
>     8184690: add Collectors for collecting into unmodifiable List, Set, and Map
>     Reviewed-by: alanb, briangoetz, dholmes, jrose, rriggs, scolebourne

> 50 lines changed: 46 ins; 0 del; 4 mod; 230 unchg

`Cdiffs Udiffs Sdiffs Frames Old New Patch Raw` test/jdk/java/util/Map/MapFactories.java

>     rev 47953 : 8177290: add copy factory methods for unmodifiable List, Set, Map
>     8184690: add Collectors for collecting into unmodifiable List, Set, and Map
>     Reviewed-by: alanb, briangoetz, dholmes, jrose, rriggs, scolebourne

> 96 lines changed: 85 ins; 1 del; 10 mod; 397 unchg

This code review page was prepared using /Users/smarks/bin/webrev (vers 25.16-hg+openjdk.java.net).