Uploaded image for project: 'Code Tools'
  1. Code Tools
  2. CODETOOLS-7900139

TestResultTable.validatePath returns false positives

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P3 P3
    • TBD_Major
    • jt4.4
    • tools

      This was initially reported as a bug against jtreg -- but jtreg is being given false info from jtharness. Specifically, TestResultTable.validatePath is returning true when it should not.

      Here is the set of files in question
      $ find jdk/test/closed/java/awt/font/Rotate/ -type f
      jdk/test/closed/java/awt/font/Rotate/RotateTest1.java
      jdk/test/closed/java/awt/font/Rotate/RotateTest1.html
      jdk/test/closed/java/awt/font/Rotate/RotateTest2.html
      jdk/test/closed/java/awt/font/Rotate/RotateTest3.html
      jdk/test/closed/java/awt/font/Rotate/ComplexTransformTest.java
      jdk/test/closed/java/awt/font/Rotate/RotateTest2.java
      jdk/test/closed/java/awt/font/Rotate/TextTransformTest.java
      jdk/test/closed/java/awt/font/Rotate/RotateTest3.java

      None of the .html files are valid test files. The corresponding .java files are valid test files.

      If I query if jdk/test/closed/java/awt/font/Rotate/RotateTest3.html is a valid path, I get a result of true, and if I set that as a test path, it is (incorrectly) treated as equivalent to jdk/test/closed/java/awt/font/Rotate/RotateTest3.java.

      Anecdotal evidence from Peter suggests that this is strongly related to the fact that the file in question (RotateTest3.html) begins with the parent directory name (Rotate).


      I've run with TestResultTable debugging switched on to 99, and get the following:
      TRT looking for closed/java/awt/font/Rotate/RotateTest3.jtr IN null
          -> Looking for branch name: closed
      TRT looking for java/awt/font/Rotate/RotateTest3.jtr IN closed
          -> Looking for branch name: java
      TRT looking for awt/font/Rotate/RotateTest3.jtr IN java
          -> Looking for branch name: awt
      TRT looking for font/Rotate/RotateTest3.jtr IN awt
          -> Looking for branch name: font
      TRT looking for Rotate/RotateTest3.jtr IN font
          -> Looking for branch name: Rotate
      TRT looking for RotateTest3.jtr IN Rotate
          -> Looking for TR in this node.
          -> TRT.findTest() located com.sun.javatest.TestResult@1b64c45

      TM.getTests validate cmdln path; closed/java/awt/font/Rotate/RotateTest3.html true


      For the record, I'll attach the full dump I have on my console.




        1. dump.txt
          7 kB
          Jonathan Gibbons

            dbessono Dmitry Bessonov
            jjg Jonathan Gibbons
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: