P3
com.sun.javatest.util.HelpTree contains a private static field which is a Comparator used to compare HelpTree.Node objects.
It should not be static and should be settable for any given HelpTree.
In particular, now that we are moving towards using GNU-style options, I want to be able to ignore leading characters like "-", "--", so that "--a" sorts near "-a" and not after "-z".
While I could file an RFE to have you change the comparator, it would be better to allow the comparator to be settable.
An equally good alternative would be to make HelpTree.Node implement Comparable<HelpTree.Node>, with a default comparator based on the current code, but allowing clients to create and use HelpTree.Node objects with a different .compareTo(HelpTree.Node other) object.
-----
For now, I'm having to use reflection to set that private static field. uuugh.
-----
As an aside, I would be remiss if I didn't also note the use of raw types (and not generic types) in this code, One of these days, you *really* will have to compile jtharness node with -Xlint:raw types and fix the issues that arise.
It should not be static and should be settable for any given HelpTree.
In particular, now that we are moving towards using GNU-style options, I want to be able to ignore leading characters like "-", "--", so that "--a" sorts near "-a" and not after "-z".
While I could file an RFE to have you change the comparator, it would be better to allow the comparator to be settable.
An equally good alternative would be to make HelpTree.Node implement Comparable<HelpTree.Node>, with a default comparator based on the current code, but allowing clients to create and use HelpTree.Node objects with a different .compareTo(HelpTree.Node other) object.
-----
For now, I'm having to use reflection to set that private static field. uuugh.
-----
As an aside, I would be remiss if I didn't also note the use of raw types (and not generic types) in this code, One of these days, you *really* will have to compile jtharness node with -Xlint:raw types and fix the issues that arise.